timers: fix refresh inside callback #26721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
timers
BridgeAR
approved these changes
Mar 17, 2019
richardlau
approved these changes
Mar 17, 2019
mscdex
reviewed
Mar 17, 2019
starkwang
approved these changes
Mar 18, 2019
3 tasks
antsmartian
approved these changes
Mar 18, 2019
antsmartian
added
the
author ready
Fishrock123
approved these changes
Mar 18, 2019
When `timers.refresh()` is called inside a callback, the timer would incorrectly end up unrefed and thus not keep the event loop alive.
apapirovski
force-pushed
the
fix-timers-refresh-in-callback
branch
from
239c9ae to
a70719a
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/21655/ (had to rebase significantly) |
|
Landed in 4306300. |
danbev
pushed a commit
that referenced
this pull request
Mar 20, 2019
When `timers.refresh()` is called inside a callback, the timer would incorrectly end up unrefed and thus not keep the event loop alive. PR-URL: #26721 Fixes: #26642 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
When `timers.refresh()` is called inside a callback, the timer would incorrectly end up unrefed and thus not keep the event loop alive. PR-URL: #26721 Fixes: #26642 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
4 tasks
zero1five
added a commit
to zero1five/node
that referenced
this pull request
Jun 13, 2019
Add an or option for put refresh back to work. nodejs#26721 one reason it can't be overridden it only works in the callback of the current timer(before `finally`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
timers.refresh()is called inside a callback, the timer would incorrectly end up unrefed and thus not keep the event loop alive.Fixes: #26642
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes